From e5166af2e4856668ea45d31e0d6fb044dc9ab1af Mon Sep 17 00:00:00 2001 From: Rohan McGovern Date: Mon, 22 Aug 2011 09:25:30 +1000 Subject: [PATCH] tests: acknowledge all known failures in declarative autotests This change XFAILs or CONFIG+=insignificant_tests all known failures in declarative autotests, and links them to bug reports. Note that the changes were only applied to qpa builds, although it is possible some of these failures affect other platforms too. Task-number: QTBUG-20990 Task-number: QTBUG-21000 Task-number: QTBUG-21001 Task-number: QTBUG-21004 Task-number: QTBUG-21005 Task-number: QTBUG-21007 Task-number: QTBUG-21008 Task-number: QTBUG-21009 Task-number: QTBUG-21010 Task-number: QTBUG-21011 Task-number: QTBUG-21012 Task-number: QTBUG-21013 Task-number: QTBUG-21015 Task-number: QTBUG-21016 Task-number: QTBUG-21017 Change-Id: Ieb89aa38e48e9e5162d87483d6441749865f234d Reviewed-on: http://codereview.qt.nokia.com/3239 Reviewed-by: Qt Sanity Bot Reviewed-by: Keith Isdale --- tests/auto/declarative/examples/examples.pro | 2 ++ tests/auto/declarative/qjsvalue/tst_qjsvalue.cpp | 3 +++ .../declarative/qsgborderimage/qsgborderimage.pro | 2 ++ tests/auto/declarative/qsgimage/tst_qsgimage.cpp | 6 ++++++ .../declarative/qsglistview/tst_qsglistview.cpp | 3 +++ .../declarative/qsgmousearea/tst_qsgmousearea.cpp | 6 ++++++ tests/auto/declarative/qsgtext/tst_qsgtext.cpp | 3 +++ tests/auto/declarative/qsgtextedit/qsgtextedit.pro | 2 ++ .../declarative/qsgtextinput/tst_qsgtextinput.cpp | 7 +++++++ .../tst_qdeclarativebehaviors.cpp | 3 +++ .../qdeclarativeflipable/qdeclarativeflipable.pro | 1 + .../qdeclarativefocusscope.pro | 1 + .../qtquick1/qdeclarativeitem/qdeclarativeitem.pro | 1 + .../qdeclarativetext/tst_qdeclarativetext.cpp | 3 +++ .../tst_qdeclarativetextedit.cpp | 3 +++ .../tst_qdeclarativetextinput.cpp | 9 +++++++++ 16 files changed, 55 insertions(+), 0 deletions(-) diff --git a/tests/auto/declarative/examples/examples.pro b/tests/auto/declarative/examples/examples.pro index 8c3c030..d159396 100644 --- a/tests/auto/declarative/examples/examples.pro +++ b/tests/auto/declarative/examples/examples.pro @@ -19,3 +19,5 @@ symbian: { CONFIG += parallel_test QT += core-private gui-private declarative-private qtquick1-private + +qpa:CONFIG+=insignificant_test # QTBUG-20990, aborts diff --git a/tests/auto/declarative/qjsvalue/tst_qjsvalue.cpp b/tests/auto/declarative/qjsvalue/tst_qjsvalue.cpp index 9f9e066..4eef465 100644 --- a/tests/auto/declarative/qjsvalue/tst_qjsvalue.cpp +++ b/tests/auto/declarative/qjsvalue/tst_qjsvalue.cpp @@ -3705,6 +3705,9 @@ void tst_QJSValue::castToPointer() QJSValue v = eng.newVariant(int(123)); int *ip = qjsvalue_cast(v); QVERIFY(ip != 0); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21000 fails", Abort); +#endif QCOMPARE(*ip, 123); QEXPECT_FAIL("", "Pointer magic for variants is currently not supported by QJSEngine", Abort); *ip = 456; diff --git a/tests/auto/declarative/qsgborderimage/qsgborderimage.pro b/tests/auto/declarative/qsgborderimage/qsgborderimage.pro index db7fe77..7b0c1d5 100644 --- a/tests/auto/declarative/qsgborderimage/qsgborderimage.pro +++ b/tests/auto/declarative/qsgborderimage/qsgborderimage.pro @@ -16,3 +16,5 @@ symbian: { CONFIG += parallel_test QT += core-private gui-private declarative-private + +qpa:CONFIG+=insignificant_test # QTBUG-21004 fails, unstably diff --git a/tests/auto/declarative/qsgimage/tst_qsgimage.cpp b/tests/auto/declarative/qsgimage/tst_qsgimage.cpp index 5ac8c21..948f36c 100644 --- a/tests/auto/declarative/qsgimage/tst_qsgimage.cpp +++ b/tests/auto/declarative/qsgimage/tst_qsgimage.cpp @@ -343,6 +343,9 @@ void tst_qsgimage::mirror() } QImage img = expected.toImage(); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21005 fails", Continue); +#endif QCOMPARE(screenshots[fillMode], img); } } @@ -469,6 +472,9 @@ void tst_qsgimage::tiling_QTBUG_6716() QImage img = canvas->grabFrameBuffer(); for (int x = 0; x < tiling->width(); ++x) { for (int y = 0; y < tiling->height(); ++y) { +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21005 fails", Abort); +#endif QVERIFY(img.pixel(x, y) == qRgb(0, 255, 0)); } } diff --git a/tests/auto/declarative/qsglistview/tst_qsglistview.cpp b/tests/auto/declarative/qsglistview/tst_qsglistview.cpp index e1e6edd..0cd10f6 100644 --- a/tests/auto/declarative/qsglistview/tst_qsglistview.cpp +++ b/tests/auto/declarative/qsglistview/tst_qsglistview.cpp @@ -1147,6 +1147,9 @@ void tst_QSGListView::enforceRange_withoutHighlight() expectedPos += 20 + 10; // scroll past 1st section and section delegate of 2nd section QTest::keyClick(canvas, Qt::Key_Down); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21007 fails", Abort); +#endif QTRY_COMPARE(listview->contentY(), expectedPos); expectedPos += 20; // scroll past 1st item of 2nd section diff --git a/tests/auto/declarative/qsgmousearea/tst_qsgmousearea.cpp b/tests/auto/declarative/qsgmousearea/tst_qsgmousearea.cpp index 6e731d1..420eda9 100644 --- a/tests/auto/declarative/qsgmousearea/tst_qsgmousearea.cpp +++ b/tests/auto/declarative/qsgmousearea/tst_qsgmousearea.cpp @@ -781,6 +781,9 @@ void tst_QSGMouseArea::hoverPosition() QMouseEvent moveEvent(QEvent::MouseMove, QPoint(10, 32), Qt::NoButton, Qt::NoButton, 0); QApplication::sendEvent(canvas, &moveEvent); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21008 fails", Abort); +#endif QCOMPARE(root->property("mouseX").toReal(), qreal(10)); QCOMPARE(root->property("mouseY").toReal(), qreal(32)); @@ -801,6 +804,9 @@ void tst_QSGMouseArea::hoverPropagation() QMouseEvent moveEvent(QEvent::MouseMove, QPoint(32, 32), Qt::NoButton, Qt::NoButton, 0); QApplication::sendEvent(canvas, &moveEvent); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21008 fails", Abort); +#endif QCOMPARE(root->property("point1").toBool(), true); QCOMPARE(root->property("point2").toBool(), false); diff --git a/tests/auto/declarative/qsgtext/tst_qsgtext.cpp b/tests/auto/declarative/qsgtext/tst_qsgtext.cpp index 747ea51..d972378 100644 --- a/tests/auto/declarative/qsgtext/tst_qsgtext.cpp +++ b/tests/auto/declarative/qsgtext/tst_qsgtext.cpp @@ -1355,6 +1355,9 @@ void tst_qsgtext::lineHeight() qreal h = myText->height(); myText->setLineHeight(1.5); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21009 fails", Continue); +#endif QVERIFY(myText->height() == h * 1.5); myText->setLineHeightMode(QSGText::FixedHeight); diff --git a/tests/auto/declarative/qsgtextedit/qsgtextedit.pro b/tests/auto/declarative/qsgtextedit/qsgtextedit.pro index fea4b71..491bb2d 100644 --- a/tests/auto/declarative/qsgtextedit/qsgtextedit.pro +++ b/tests/auto/declarative/qsgtextedit/qsgtextedit.pro @@ -14,3 +14,5 @@ symbian: { } QT += core-private gui-private declarative-private QT += opengl-private + +qpa:CONFIG+=insignificant_test # QTBUG-21010, fails unstably diff --git a/tests/auto/declarative/qsgtextinput/tst_qsgtextinput.cpp b/tests/auto/declarative/qsgtextinput/tst_qsgtextinput.cpp index 744717c..9761180 100644 --- a/tests/auto/declarative/qsgtextinput/tst_qsgtextinput.cpp +++ b/tests/auto/declarative/qsgtextinput/tst_qsgtextinput.cpp @@ -1267,6 +1267,10 @@ void tst_qsgtextinput::positionAt() diff = abs(int(textLeftWidth-textinputObject->width()/2)); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21011 fails", Continue); +#endif + // some tollerance for different fonts. #ifdef Q_OS_LINUX QVERIFY(diff < 2); @@ -2309,6 +2313,9 @@ void tst_qsgtextinput::preeditAutoScroll() // test the text is scrolled so the preedit is visible. ic.sendPreeditText(preeditText.mid(0, 3), 1); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21011 fails", Abort); +#endif QVERIFY(input->positionAt(0) != 0); QVERIFY(input->cursorRectangle().left() < input->boundingRect().width()); QCOMPARE(cursorRectangleSpy.count(), ++cursorRectangleChanges); diff --git a/tests/auto/qtquick1/qdeclarativebehaviors/tst_qdeclarativebehaviors.cpp b/tests/auto/qtquick1/qdeclarativebehaviors/tst_qdeclarativebehaviors.cpp index 773fc24..68efbe1 100644 --- a/tests/auto/qtquick1/qdeclarativebehaviors/tst_qdeclarativebehaviors.cpp +++ b/tests/auto/qtquick1/qdeclarativebehaviors/tst_qdeclarativebehaviors.cpp @@ -401,6 +401,9 @@ void tst_qdeclarativebehaviors::sameValue() QCOMPARE(target->x(), qreal(100)); target->setProperty("x", 0); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21001 fails", Abort); +#endif QTRY_VERIFY(target->x() != qreal(0) && target->x() != qreal(100)); QTRY_VERIFY(target->x() == qreal(0)); //make sure Behavior has finished. diff --git a/tests/auto/qtquick1/qdeclarativeflipable/qdeclarativeflipable.pro b/tests/auto/qtquick1/qdeclarativeflipable/qdeclarativeflipable.pro index 64d5d0a..22d015c 100644 --- a/tests/auto/qtquick1/qdeclarativeflipable/qdeclarativeflipable.pro +++ b/tests/auto/qtquick1/qdeclarativeflipable/qdeclarativeflipable.pro @@ -15,3 +15,4 @@ symbian: { CONFIG += parallel_test QT += core-private gui-private declarative-private qtquick1-private +qpa:contains(QT_CONFIG,xcb):CONFIG+=insignificant_test # QTBUG-21012 fails on exit (X11-specific) diff --git a/tests/auto/qtquick1/qdeclarativefocusscope/qdeclarativefocusscope.pro b/tests/auto/qtquick1/qdeclarativefocusscope/qdeclarativefocusscope.pro index f532585..5e943d7 100644 --- a/tests/auto/qtquick1/qdeclarativefocusscope/qdeclarativefocusscope.pro +++ b/tests/auto/qtquick1/qdeclarativefocusscope/qdeclarativefocusscope.pro @@ -12,3 +12,4 @@ symbian: { } QT += core-private gui-private declarative-private qtquick1-private +qpa:CONFIG+=insignificant_test # QTBUG-21013 unstable diff --git a/tests/auto/qtquick1/qdeclarativeitem/qdeclarativeitem.pro b/tests/auto/qtquick1/qdeclarativeitem/qdeclarativeitem.pro index 0b87e3c..459f80b 100644 --- a/tests/auto/qtquick1/qdeclarativeitem/qdeclarativeitem.pro +++ b/tests/auto/qtquick1/qdeclarativeitem/qdeclarativeitem.pro @@ -15,3 +15,4 @@ symbian: { CONFIG += parallel_test QT += core-private gui-private declarative-private qtquick1-private +qpa:contains(QT_CONFIG,xcb):CONFIG+=insignificant_test # QTBUG-21012 fails on exit (X11-specific) diff --git a/tests/auto/qtquick1/qdeclarativetext/tst_qdeclarativetext.cpp b/tests/auto/qtquick1/qdeclarativetext/tst_qdeclarativetext.cpp index d6984cb..8398ec6 100644 --- a/tests/auto/qtquick1/qdeclarativetext/tst_qdeclarativetext.cpp +++ b/tests/auto/qtquick1/qdeclarativetext/tst_qdeclarativetext.cpp @@ -1329,6 +1329,9 @@ void tst_qdeclarativetext::lineHeight() qreal h = myText->height(); myText->setLineHeight(1.5); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21015 fails", Continue); +#endif QVERIFY(myText->height() == h * 1.5); myText->setLineHeightMode(QDeclarative1Text::FixedHeight); diff --git a/tests/auto/qtquick1/qdeclarativetextedit/tst_qdeclarativetextedit.cpp b/tests/auto/qtquick1/qdeclarativetextedit/tst_qdeclarativetextedit.cpp index 94378e9..76f4687 100644 --- a/tests/auto/qtquick1/qdeclarativetextedit/tst_qdeclarativetextedit.cpp +++ b/tests/auto/qtquick1/qdeclarativetextedit/tst_qdeclarativetextedit.cpp @@ -1617,6 +1617,9 @@ void tst_qdeclarativetextedit::positionAt() int pos = texteditObject->positionAt(texteditObject->width()/2, y0); int diff = abs(int(fm.width(texteditObject->text().left(pos))-texteditObject->width()/2)); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21016 fails", Continue); +#endif // some tollerance for different fonts. #ifdef Q_OS_LINUX QVERIFY(diff < 2); diff --git a/tests/auto/qtquick1/qdeclarativetextinput/tst_qdeclarativetextinput.cpp b/tests/auto/qtquick1/qdeclarativetextinput/tst_qdeclarativetextinput.cpp index 7cc79c7..2d86a4b 100644 --- a/tests/auto/qtquick1/qdeclarativetextinput/tst_qdeclarativetextinput.cpp +++ b/tests/auto/qtquick1/qdeclarativetextinput/tst_qdeclarativetextinput.cpp @@ -1324,6 +1324,9 @@ void tst_qdeclarativetextinput::positionAt() pos = textinputObject->positionAt(textinputObject->width()/2); diff = abs(int(fm.width(textinputObject->text().left(pos))-textinputObject->width()/2)); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21017 fails", Continue); +#endif // some tollerance for different fonts. #ifdef Q_OS_LINUX QVERIFY(diff < 2); @@ -2336,6 +2339,9 @@ void tst_qdeclarativetextinput::setHAlignClearCache() view.show(); QApplication::setActiveWindow(&view); QTest::qWaitForWindowShown(&view); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21017 fails", Abort); +#endif QTRY_COMPARE(input.nbPaint, 1); input.setHAlign(QDeclarative1TextInput::AlignRight); QApplication::processEvents(); @@ -2444,6 +2450,9 @@ void tst_qdeclarativetextinput::preeditAutoScroll() // test the text is scrolled so the preedit is visible. ic.sendPreeditText(preeditText.mid(0, 3), 1); +#ifdef Q_WS_QPA + QEXPECT_FAIL("", "QTBUG-21017 fails", Abort); +#endif QVERIFY(input.positionAt(0) != 0); QVERIFY(input.cursorRectangle().left() < input.boundingRect().width()); QCOMPARE(cursorRectangleSpy.count(), ++cursorRectangleChanges); -- 1.7.2.5