From cede252f2d0ff41be86aeacea019fce1f9db18df Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C4=99drzej=20Nowacki?= Date: Mon, 5 Sep 2011 17:14:21 +0200 Subject: [PATCH] Remove dead code. Last time when I checked using ExternalStringResources was slower then normal strings. Probably in future we may reevaluate this idea. Change-Id: I9e8d971be146a29256d4e01e4fae6e50cfe42c80 Reviewed-on: http://codereview.qt-project.org/4245 Reviewed-by: Qt Sanity Bot Reviewed-by: Aaron Kennedy --- src/declarative/qml/v8/qv8stringwrapper.cpp | 15 --------------- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/src/declarative/qml/v8/qv8stringwrapper.cpp b/src/declarative/qml/v8/qv8stringwrapper.cpp index 1fea98f..a1db580 100644 --- a/src/declarative/qml/v8/qv8stringwrapper.cpp +++ b/src/declarative/qml/v8/qv8stringwrapper.cpp @@ -44,17 +44,6 @@ QT_BEGIN_NAMESPACE -class QV8StringResource : public v8::String::ExternalStringResource -{ -public: - QV8StringResource(const QString &str) : str(str) {} - virtual const uint16_t* data() const { return (uint16_t*)str.constData(); } - virtual size_t length() const { return str.length(); } - virtual void Dispose() { delete this; } - - QString str; -}; - QV8StringWrapper::QV8StringWrapper() { } @@ -73,7 +62,6 @@ void QV8StringWrapper::destroy() v8::Local QV8StringWrapper::toString(const QString &qstr) { -// return v8::String::NewExternal(new QV8StringResource(qstr)); return QJSConverter::toString(qstr); } @@ -81,9 +69,6 @@ QString QV8StringWrapper::toString(v8::Handle jsstr) { if (jsstr.IsEmpty()) { return QString(); - } else if (jsstr->IsExternal()) { - QV8StringResource *r = (QV8StringResource *)jsstr->GetExternalStringResource(); - return r->str; } else { return QJSConverter::toString(jsstr); } -- 1.7.2.5