From a617073f6b93f01f112f92a80b52247daa951713 Mon Sep 17 00:00:00 2001 From: Christian Kamm Date: Tue, 4 Oct 2011 12:22:07 +0200 Subject: [PATCH] qmlplugindump: Add test for running with -builtins. The main idea is to check for crashes: When instantiable C++ based QML components have uninitialized QObject * members, qmlplugindump can crash while collecting types to dump. That will make it impossible for users to use qmlplugindump and should be fixed in the responsible classes constructor. On unix it has a crash handler that tries to pinpoint which class and property caused the problem. Change-Id: Ie049cae27d94920f3d8346ca7075eba5a11c2a37 Reviewed-on: http://codereview.qt-project.org/5976 Reviewed-by: Roberto Raggi --- tests/auto/declarative/declarative.pro | 3 +- .../declarative/qmlplugindump/qmlplugindump.pro | 5 + .../qmlplugindump/tst_qmlplugindump.cpp | 111 ++++++++++++++++++++ 3 files changed, 118 insertions(+), 1 deletions(-) create mode 100644 tests/auto/declarative/qmlplugindump/qmlplugindump.pro create mode 100644 tests/auto/declarative/qmlplugindump/tst_qmlplugindump.cpp diff --git a/tests/auto/declarative/declarative.pro b/tests/auto/declarative/declarative.pro index 60eb2a9..f02bc51 100644 --- a/tests/auto/declarative/declarative.pro +++ b/tests/auto/declarative/declarative.pro @@ -24,7 +24,8 @@ PUBLICTESTS += \ qjsvalue \ qjsvalueiterator \ qjsengine \ - qmlmin + qmlmin \ + qmlplugindump PRIVATETESTS += \ qdeclarativeanimations \ diff --git a/tests/auto/declarative/qmlplugindump/qmlplugindump.pro b/tests/auto/declarative/qmlplugindump/qmlplugindump.pro new file mode 100644 index 0000000..ce0a566 --- /dev/null +++ b/tests/auto/declarative/qmlplugindump/qmlplugindump.pro @@ -0,0 +1,5 @@ +load(qttest_p4) +macx:CONFIG -= app_bundle +CONFIG += parallel_test + +SOURCES += tst_qmlplugindump.cpp diff --git a/tests/auto/declarative/qmlplugindump/tst_qmlplugindump.cpp b/tests/auto/declarative/qmlplugindump/tst_qmlplugindump.cpp new file mode 100644 index 0000000..234d4bc --- /dev/null +++ b/tests/auto/declarative/qmlplugindump/tst_qmlplugindump.cpp @@ -0,0 +1,111 @@ +/**************************************************************************** +** +** Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies). +** All rights reserved. +** Contact: Nokia Corporation (qt-info@nokia.com) +** +** This file is part of the test suite of the Qt Toolkit. +** +** $QT_BEGIN_LICENSE:LGPL$ +** GNU Lesser General Public License Usage +** This file may be used under the terms of the GNU Lesser General Public +** License version 2.1 as published by the Free Software Foundation and +** appearing in the file LICENSE.LGPL included in the packaging of this +** file. Please review the following information to ensure the GNU Lesser +** General Public License version 2.1 requirements will be met: +** http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html. +** +** In addition, as a special exception, Nokia gives you certain additional +** rights. These rights are described in the Nokia Qt LGPL Exception +** version 1.1, included in the file LGPL_EXCEPTION.txt in this package. +** +** GNU General Public License Usage +** Alternatively, this file may be used under the terms of the GNU General +** Public License version 3.0 as published by the Free Software Foundation +** and appearing in the file LICENSE.GPL included in the packaging of this +** file. Please review the following information to ensure the GNU General +** Public License version 3.0 requirements will be met: +** http://www.gnu.org/copyleft/gpl.html. +** +** Other Usage +** Alternatively, this file may be used in accordance with the terms and +** conditions contained in a signed written agreement between you and Nokia. +** +** +** +** +** +** $QT_END_LICENSE$ +** +****************************************************************************/ + +#include +#include +#include +#include +#include +#include + +class tst_qmlplugindump : public QObject +{ + Q_OBJECT +public: + tst_qmlplugindump(); + +private slots: + void initTestCase(); + void builtins(); + +private: + QString qmlplugindumpPath; +}; + +tst_qmlplugindump::tst_qmlplugindump() +{ +} + +void tst_qmlplugindump::initTestCase() +{ + qmlplugindumpPath = QLibraryInfo::location(QLibraryInfo::BinariesPath) + QLatin1String("/qmlplugindump"); +#ifdef Q_OS_WIN + qmlplugindumpPath += QLatin1String(".exe"); +#endif + if (!QFileInfo(qmlplugindumpPath).exists()) { + QString message = QString::fromLatin1("qmlplugindump executable not found (looked for %0)") + .arg(qmlplugindumpPath); + QFAIL(qPrintable(message)); + } +} + +void tst_qmlplugindump::builtins() +{ + QProcess dumper; + QStringList args; + args += QLatin1String("-builtins"); + dumper.start(qmlplugindumpPath, args); + dumper.waitForFinished(); + + if (dumper.error() != QProcess::UnknownError + || dumper.exitStatus() != QProcess::NormalExit) { + qWarning() << QString("Error while running '%1 %2'").arg( + qmlplugindumpPath, args.join(QLatin1String(" "))); + } + + if (dumper.error() == QProcess::FailedToStart) { + QFAIL("failed to start"); + } + if (dumper.error() == QProcess::Crashed) { + qWarning() << "stderr:\n" << dumper.readAllStandardError(); + QFAIL("crashed"); + } + + QCOMPARE(dumper.error(), QProcess::UnknownError); + QCOMPARE(dumper.exitStatus(), QProcess::NormalExit); + + const QString &result = dumper.readAllStandardOutput(); + QVERIFY(result.contains(QLatin1String("Module {"))); +} + +QTEST_MAIN(tst_qmlplugindump) + +#include "tst_qmlplugindump.moc" -- 1.7.2.5