From 61f2b2a9d81a40de4842c44a307fba7ab07f6840 Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Mon, 6 May 2013 14:09:40 +0200 Subject: [PATCH] Use plain string comparison which is twice as fast --- lib/Twig/Extension/Core.php | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/lib/Twig/Extension/Core.php b/lib/Twig/Extension/Core.php index 38ac008..e0a6a33 100644 --- a/lib/Twig/Extension/Core.php +++ b/lib/Twig/Extension/Core.php @@ -948,7 +948,9 @@ function twig_escape_filter(Twig_Environment $env, $string, $strategy = 'html', return $string; case 'url': - if (version_compare(PHP_VERSION, '5.3.0', '<')) { + // hackish test to avoid version_compare that is much slower, this works unless PHP releases a 5.10.* + // at that point however PHP 5.2.* support can be removed + if (PHP_VERSION < '5.3.0') { return str_replace('%7E', '~', rawurlencode($string)); } -- 1.7.2.5