From: Fabien Potencier Date: Mon, 9 Apr 2012 16:27:10 +0000 (+0200) Subject: merged branch Tobion/random-fix (PR #693) X-Git-Url: http://git.silmor.de/gitweb/?a=commitdiff_plain;h=fd634d1af20fb41dd4e9f7b23806513a6a6b8110;p=konrad%2Ftwig.git merged branch Tobion/random-fix (PR #693) Commits ------- 06361ca added note in changelog 2706412 fixed random function when charset is null Discussion ---------- Fixed random function when charset is null Fixed random function when charset is null and the value is an empty string, resulting in an mt_rand error max(-1) is smaller than min(0). Also fixed a test on windows. But I don't know why you introduced the special handling for `null === $env->getCharset()`. Why is that necessary and why is it possible to have a null charset at all? Usually it defaults to utf-8 anyway. --- fd634d1af20fb41dd4e9f7b23806513a6a6b8110