From: Fabien Potencier Date: Sun, 1 Apr 2012 08:22:57 +0000 (+0200) Subject: merged branch Nami-Doc/patch-1 (PR #680) X-Git-Url: http://git.silmor.de/gitweb/?a=commitdiff_plain;h=e3b5998a6de48a5d57a382a0653898deb6795521;p=web%2Fkonrad%2Ftwig.git merged branch Nami-Doc/patch-1 (PR #680) Commits ------- 27ffef0 The question I'm asking myself now is : how could I get $trace['line'] is not set if there's a check before the <= ? anyway, fixed 36618fe fix a bug where when an error would be thrown through the loader (Twig_Error_Loader by Twig_Loader_Filesystem, ie) the $trace['line'] would not be set (since we're not in a template) Discussion ---------- fix a bug where when an error would be thrown through the loader (Twig_Error_Loader by Twig_Loader_Filesystem, ie) the $trace['line'] would not be set (since we're not in a template) thanks --------------------------------------------------------------------------- by Nami-Doc at 2012-03-31T20:00:31Z fixed, thanks @stof. Now I wonder (as I just wrote) : how could I get the error with that isset here ? --------------------------------------------------------------------------- by stof at 2012-03-31T20:05:45Z @Nami-Doc what was the exact error you got ? --------------------------------------------------------------------------- by Nami-Doc at 2012-03-31T20:09:51Z Php states that $trace['line'] isn't set --------------------------------------------------------------------------- by Nami-Doc at 2012-03-31T20:23:33Z O.K., got it. this has been fixed in #675, but composer (great tool) installed me last tag, but I think it's better to check it outside the loop anyway (micro-micro-optimisation) --- e3b5998a6de48a5d57a382a0653898deb6795521