From: Jędrzej Nowacki <jedrzej.nowacki@nokia.com>
Date: Mon, 5 Sep 2011 15:14:21 +0000 (+0200)
Subject: Remove dead code.
X-Git-Url: http://git.silmor.de/gitweb/?a=commitdiff_plain;h=cede252f2d0ff41be86aeacea019fce1f9db18df;p=konrad%2Fqtdeclarative.git

Remove dead code.

Last time when I checked using ExternalStringResources was slower then
normal strings. Probably in future we may reevaluate this idea.

Change-Id: I9e8d971be146a29256d4e01e4fae6e50cfe42c80
Reviewed-on: http://codereview.qt-project.org/4245
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
---

diff --git a/src/declarative/qml/v8/qv8stringwrapper.cpp b/src/declarative/qml/v8/qv8stringwrapper.cpp
index 1fea98f..a1db580 100644
--- a/src/declarative/qml/v8/qv8stringwrapper.cpp
+++ b/src/declarative/qml/v8/qv8stringwrapper.cpp
@@ -44,17 +44,6 @@
 
 QT_BEGIN_NAMESPACE
 
-class QV8StringResource : public v8::String::ExternalStringResource
-{
-public:
-    QV8StringResource(const QString &str) : str(str) {}
-    virtual const uint16_t* data() const { return (uint16_t*)str.constData(); }
-    virtual size_t length() const { return str.length(); }
-    virtual void Dispose() { delete this; }
-
-    QString str;
-};
-
 QV8StringWrapper::QV8StringWrapper()
 {
 }
@@ -73,7 +62,6 @@ void QV8StringWrapper::destroy()
 
 v8::Local<v8::String> QV8StringWrapper::toString(const QString &qstr)
 {
-//    return v8::String::NewExternal(new QV8StringResource(qstr));
     return QJSConverter::toString(qstr);
 }
 
@@ -81,9 +69,6 @@ QString QV8StringWrapper::toString(v8::Handle<v8::String> jsstr)
 {
     if (jsstr.IsEmpty()) {
         return QString();
-    } else if (jsstr->IsExternal()) {
-        QV8StringResource *r = (QV8StringResource *)jsstr->GetExternalStringResource();
-        return r->str;
     } else {
         return QJSConverter::toString(jsstr);
     }