From: Fabien Potencier Date: Tue, 18 Sep 2012 09:34:35 +0000 (+0200) Subject: merged branch drak/reusable_fixtures (PR #805) X-Git-Url: http://git.silmor.de/gitweb/?a=commitdiff_plain;h=bd7f04e38e027b8b68c4207f0000eca1e890d8df;p=web%2Fkonrad%2Ftwig.git merged branch drak/reusable_fixtures (PR #805) Commits ------- 36372c6 Made node tests reusable Discussion ---------- Reusable tests and fixtures This PR makes Twig integration testing reusable for 3rd party extensions. I have implemented resuable functional tests. The [test runner](https://github.com/zikula/core/blob/master/src/Zikula/Bundle/CoreBundle/Tests/Twig/IntegrationTest.php) and the [fixtures](https://github.com/zikula/core/tree/master/src/Zikula/Bundle/CoreBundle/Tests/Twig/Fixtures) are the only part that an extension needs to implement itself. I've included documentation in the PR. --------------------------------------------------------------------------- by jusuff at 2012-08-11T20:41:55Z This PR would make things little easier. Right now tests are organized in confusing way and are hard to implement for Twig extensions --------------------------------------------------------------------------- by drak at 2012-08-14T09:09:45Z @fabpot - This is ready for merging now. When it's merged I'll update the documentation as this PR significantly eases our ability to test extensions. --------------------------------------------------------------------------- by fabpot at 2012-09-16T14:28:16Z @drak Do you plan to update this PR with the code you have in Zikula? --------------------------------------------------------------------------- by drak at 2012-09-16T14:37:30Z @fabpot - Yes, I just need a couple of days (or less). --------------------------------------------------------------------------- by drak at 2012-09-17T12:00:34Z @fabpot - I have ported over the code. --------------------------------------------------------------------------- by drak at 2012-09-18T08:23:18Z @fabpot - I updated Zikula to us this particular branch so there is a practical test. I've updated the links in the top description part of this PR with the relevant links. The PR also refactors Twig's core tests to use the re-usable test base classes. --------------------------------------------------------------------------- by fabpot at 2012-09-18T09:01:10Z @drak Can you squash your commits before I merge? Thanks. --------------------------------------------------------------------------- by drak at 2012-09-18T09:14:08Z @fabpot - I've squashed them now. Thanks! --- bd7f04e38e027b8b68c4207f0000eca1e890d8df