From: Fabien Potencier Date: Tue, 12 Jul 2011 07:49:44 +0000 (+0200) Subject: merged branch nikic/improveIsDefinedPerformanceInNonStrictMode (PR #381) X-Git-Url: http://git.silmor.de/gitweb/?a=commitdiff_plain;h=90d99a7737270b2720b8ba88a9ad70dedade9cd5;p=web%2Fkonrad%2Ftwig.git merged branch nikic/improveIsDefinedPerformanceInNonStrictMode (PR #381) Commits ------- e4b8371 Improve performance of is defined in non strict mode Discussion ---------- Improve performance of is defined in non strict mode Addresses issue #380: This gives a good performance improvement on defined tests in non-strict code. About 2x. Reasoning: It doesn't make sense to propagate the `is_defined_test` flag into deeper levels in non-strict mode, because all getAttr functions and name accesses will just return `null` if it doesn't exist and `null` is just as good as `false`. --------------------------------------------------------------------------- by nikic at 2011/07/02 03:22:53 -0700 Though, do not merge yet please. Changes behavior concerning methods. --------------------------------------------------------------------------- by nikic at 2011/07/02 13:34:32 -0700 Hm, I really don't know what I was thinking when I wrote my last comment. There shouldn't be any behavior changes introduced by that change (and tests pass). --- 90d99a7737270b2720b8ba88a9ad70dedade9cd5