Remove dead code from QJSValuePrivate
authorKent Hansen <kent.hansen@nokia.com>
Thu, 4 Aug 2011 11:42:15 +0000 (13:42 +0200)
committerQt by Nokia <qt-info@nokia.com>
Thu, 4 Aug 2011 12:38:49 +0000 (14:38 +0200)
reinitialize() was used to implement setGlobalObject()
and setScriptClass() in the QtScript/V8 port, but those
functions will not be part of the new JS API.

Change-Id: I030d371659136a407636c7a13afe7623a60a2837
Reviewed-on: http://codereview.qt.nokia.com/2623
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: JÄ™drzej Nowacki <jedrzej.nowacki@nokia.com>

src/declarative/qml/v8/qjsvalue_impl_p.h
src/declarative/qml/v8/qjsvalue_p.h

index 1970505..414109c 100644 (file)
@@ -1051,26 +1051,6 @@ void QJSValuePrivate::reinitialize()
     m_state = Invalid;
 }
 
-/*!
-  \internal
-  reinitialize this value to an JSValue.
-*/
-void QJSValuePrivate::reinitialize(QV8Engine* engine, v8::Handle<v8::Value> value)
-{
-    Q_ASSERT_X(this != InvalidValue(), Q_FUNC_INFO, "static invalid can't be reinitialized to a different value");
-    if (isJSBased()) {
-        m_value.Dispose();
-        // avoid double registration
-        m_engine->unregisterValue(this);
-    } else if (isStringBased()) {
-        delete u.m_string;
-    }
-    m_engine = engine;
-    m_state = JSValue;
-    m_value = v8::Persistent<v8::Value>::New(value);
-    m_engine->registerValue(this);
-}
-
 QV8Engine* QJSValuePrivate::engine() const
 {
     return m_engine;
index 8189f45..b50f573 100644 (file)
@@ -82,7 +82,6 @@ public:
     inline QJSValuePrivate(QV8Engine *engine, QJSValue::SpecialValue value);
     inline QJSValuePrivate(QV8Engine *engine, v8::Handle<v8::Value>);
     inline void reinitialize();
-    inline void reinitialize(QV8Engine *engine, v8::Handle<v8::Value> value);
 
     inline bool toBool() const;
     inline double toNumber() const;