projects
/
konrad/qtdeclarative.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
(parent:
d8ac2c1
)
Fix memory leaks with QV8Engine's ExtensionData
author
Simon Hausmann
<simon.hausmann@nokia.com>
Wed, 20 Jul 2011 08:50:21 +0000 (10:50 +0200)
committer
Qt by Nokia
<qt-info@nokia.com>
Wed, 20 Jul 2011 09:39:58 +0000 (11:39 +0200)
The destructor has to be virtual for Deletable in order to call
the destructor of the super-class.
Change-Id: I3aeebe28c0a6bbfbbe3b069e88a6096dd9e173f5
Reviewed-on: http://codereview.qt.nokia.com/1867
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
src/declarative/qml/v8/qv8engine_p.h
patch
|
blob
|
history
diff --git
a/src/declarative/qml/v8/qv8engine_p.h
b/src/declarative/qml/v8/qv8engine_p.h
index
6c05fe4
..
d9f4fee
100644
(file)
--- a/
src/declarative/qml/v8/qv8engine_p.h
+++ b/
src/declarative/qml/v8/qv8engine_p.h
@@
-213,7
+213,7
@@
public:
~QV8Engine();
struct Deletable {
- ~Deletable() {}
+ virtual ~Deletable() {}
};
void init(QDeclarativeEngine *);