QmlDebugging: Remove QQmlDebugClient
authorAurindam Jana <aurindam.jana@nokia.com>
Tue, 6 Mar 2012 13:59:29 +0000 (14:59 +0100)
committerQt by Nokia <qt-info@nokia.com>
Fri, 9 Mar 2012 08:48:24 +0000 (09:48 +0100)
Remove QQmlDebugClient and relevant classes from the
library and move to client code.

Change-Id: I6f526b3f0c92970dcad5e5abd8585bb9b406349e
Reviewed-by: Kai Koehne <kai.koehne@nokia.com>

30 files changed:
src/qml/debugger/debugger.pri
tests/auto/qml/debugger/debugger.pro
tests/auto/qml/debugger/qdebugmessageservice/qdebugmessageservice.pro
tests/auto/qml/debugger/qdebugmessageservice/tst_qdebugmessageservice.cpp
tests/auto/qml/debugger/qpacketprotocol/qpacketprotocol.pro
tests/auto/qml/debugger/qpacketprotocol/tst_qpacketprotocol.cpp
tests/auto/qml/debugger/qqmldebugclient/qqmldebugclient.pro
tests/auto/qml/debugger/qqmldebugclient/tst_qqmldebugclient.cpp
tests/auto/qml/debugger/qqmldebugjs/qqmldebugjs.pro
tests/auto/qml/debugger/qqmldebugjs/tst_qqmldebugjs.cpp
tests/auto/qml/debugger/qqmldebugservice/qqmldebugservice.pro
tests/auto/qml/debugger/qqmldebugservice/tst_qqmldebugservice.cpp
tests/auto/qml/debugger/qqmlenginedebugservice/qqmlenginedebugservice.pro [moved from tests/auto/qml/debugger/qqmlenginedebug/qqmlenginedebug.pro with 52% similarity]
tests/auto/qml/debugger/qqmlenginedebugservice/tst_qqmlenginedebugservice.cpp [moved from tests/auto/qml/debugger/qqmlenginedebug/tst_qqmlenginedebug.cpp with 94% similarity]
tests/auto/qml/debugger/qqmlinspector/tst_qqmlinspector.pro
tests/auto/qml/debugger/qqmlprofilerservice/qqmlprofilerservice.pro
tests/auto/qml/debugger/qqmlprofilerservice/tst_qqmlprofilerservice.cpp
tests/auto/qml/debugger/qv8profilerservice/qv8profilerservice.pro
tests/auto/qml/debugger/qv8profilerservice/tst_qv8profilerservice.cpp
tests/auto/qml/debugger/shared/debugutil.cpp
tests/auto/qml/debugger/shared/debugutil.pri [new file with mode: 0644]
tests/auto/qml/debugger/shared/debugutil_p.h
tests/auto/qml/debugger/shared/qqmldebugclient.cpp [copied from src/qml/debugger/qqmldebugclient.cpp with 96% similarity]
tests/auto/qml/debugger/shared/qqmldebugclient.h [copied from src/qml/debugger/qqmldebugclient_p.h with 91% similarity]
tests/auto/qml/debugger/shared/qqmlenginedebug.cpp [moved from src/qml/debugger/qqmlenginedebug.cpp with 99% similarity]
tests/auto/qml/debugger/shared/qqmlenginedebug_p.h [moved from src/qml/debugger/qqmlenginedebug_p.h with 99% similarity]
tools/qmlprofiler/profileclient.h
tools/qmlprofiler/qmlprofiler.pro
tools/qmlprofiler/qqmldebugclient.cpp [moved from src/qml/debugger/qqmldebugclient.cpp with 96% similarity]
tools/qmlprofiler/qqmldebugclient.h [moved from src/qml/debugger/qqmldebugclient_p.h with 86% similarity]

index f85663c..f5abd2c 100644 (file)
@@ -1,8 +1,6 @@
 SOURCES += \
     $$PWD/qpacketprotocol.cpp \
     $$PWD/qqmldebugservice.cpp \
-    $$PWD/qqmldebugclient.cpp \
-    $$PWD/qqmlenginedebug.cpp \
     $$PWD/qqmlprofilerservice.cpp \
     $$PWD/qqmldebugserver.cpp \
     $$PWD/qqmlinspectorservice.cpp \
@@ -15,8 +13,6 @@ HEADERS += \
     $$PWD/qpacketprotocol_p.h \
     $$PWD/qqmldebugservice_p.h \
     $$PWD/qqmldebugservice_p_p.h \
-    $$PWD/qqmldebugclient_p.h \
-    $$PWD/qqmlenginedebug_p.h \
     $$PWD/qqmlprofilerservice_p.h \
     $$PWD/qqmldebugserver_p.h \
     $$PWD/qqmldebugserverconnection_p.h \
index 4f9ebbc..7669aaa 100644 (file)
@@ -1,7 +1,7 @@
 TEMPLATE = subdirs
 
 PRIVATETESTS += \
-    qqmlenginedebug \
+    qqmlenginedebugservice \
     qqmldebugclient \
     qqmldebugservice \
     qqmldebugjs \
index d62a262..4b5bf60 100644 (file)
@@ -3,14 +3,11 @@ TARGET = tst_qdebugmessageservice
 QT += network qml-private testlib
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
-
-SOURCES +=     tst_qdebugmessageservice.cpp \
-            ../shared/debugutil.cpp
+SOURCES +=     tst_qdebugmessageservice.cpp
 
 INCLUDEPATH += ../shared
-
 include(../../../shared/util.pri)
+include(../shared/debugutil.pri)
 
 TESTDATA = data/*
 
index a19fd4b..8473774 100644 (file)
 **
 ****************************************************************************/
 
-#include <QtQml/private/qqmldebugclient_p.h>
+#include "qqmldebugclient.h"
 
 //QQmlDebugTest
-#include "../shared/debugutil_p.h"
+#include "debugutil_p.h"
 #include "../../../shared/util.h"
 
 #include <QtCore/QString>
index 8843919..f631929 100644 (file)
@@ -2,9 +2,10 @@ CONFIG += testcase
 TARGET = tst_qpacketprotocol
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
-SOURCES += tst_qpacketprotocol.cpp \
-           ../shared/debugutil.cpp
+SOURCES += tst_qpacketprotocol.cpp
+
+INCLUDEPATH += ../shared
+include(../shared/debugutil.pri)
 
 CONFIG += parallel_test
 QT += qml-private network testlib
index c02dd2d..4a6efb4 100644 (file)
@@ -48,7 +48,7 @@
 
 #include <private/qpacketprotocol_p.h>
 
-#include "../shared/debugutil_p.h"
+#include "debugutil_p.h"
 
 class tst_QPacketProtocol : public QObject
 {
index d298b5c..22a4df7 100644 (file)
@@ -2,9 +2,10 @@ CONFIG += testcase
 TARGET = tst_qqmldebugclient
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
-SOURCES += tst_qqmldebugclient.cpp \
-           ../shared/debugutil.cpp
+SOURCES += tst_qqmldebugclient.cpp
+
+INCLUDEPATH += ../shared
+include(../shared/debugutil.pri)
 
 CONFIG += declarative_debug
 
index b18f30f..9377ef6 100644 (file)
@@ -47,7 +47,7 @@
 
 #include <QtQml/qqmlengine.h>
 
-#include "../shared/debugutil_p.h"
+#include "debugutil_p.h"
 
 #define PORT 13770
 #define STR_PORT "13770"
index 7bb5161..7c3a2ea 100644 (file)
@@ -3,13 +3,11 @@ TARGET = tst_qqmldebugjs
 QT += qml-private testlib
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
-SOURCES +=     tst_qqmldebugjs.cpp \
-            ../shared/debugutil.cpp
+SOURCES +=     tst_qqmldebugjs.cpp
 
 INCLUDEPATH += ../shared
-
-include (../../../shared/util.pri)
+include(../../../shared/util.pri)
+include(../shared/debugutil.pri)
 
 TESTDATA = data/*
 
index 9a8b00b..9cd021d 100644 (file)
 #include <QtCore/QDir>
 #include <QtCore/QMutex>
 #include <QtCore/QLibraryInfo>
-#include <QtQml/private/qqmldebugclient_p.h>
 #include <QtQml/QJSEngine>
 
 //QQmlDebugTest
-#include "../shared/debugutil_p.h"
+#include "debugutil_p.h"
+#include "qqmldebugclient.h"
 #include "../../../shared/util.h"
 
 const char *V8REQUEST = "v8request";
index ecb3b2c..dc20396 100644 (file)
@@ -2,9 +2,10 @@ CONFIG += testcase
 TARGET = tst_qqmldebugservice
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
-SOURCES += tst_qqmldebugservice.cpp \
-           ../shared/debugutil.cpp
+SOURCES += tst_qqmldebugservice.cpp
+INCLUDEPATH += ../shared
+include(../../../shared/util.pri)
+include(../shared/debugutil.pri)
 
 CONFIG += parallel_test declarative_debug
 
index 3699530..a7fc284 100644 (file)
 
 #include <QtQml/qqmlengine.h>
 
-#include <private/qqmldebugclient_p.h>
 #include <private/qqmldebugservice_p.h>
 
 #include "../../../shared/util.h"
-#include "../shared/debugutil_p.h"
+#include "debugutil_p.h"
+#include "qqmldebugclient.h"
 
 #define PORT 13769
 #define STR_PORT "13769"
@@ -1,10 +1,11 @@
 CONFIG += testcase
-TARGET = tst_qqmlenginedebug
+TARGET = tst_qqmlenginedebugservice
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
-SOURCES += tst_qqmlenginedebug.cpp \
-           ../shared/debugutil.cpp
+SOURCES += tst_qqmlenginedebugservice.cpp
+
+INCLUDEPATH += ../shared
+include(../shared/debugutil.pri)
 
 CONFIG += parallel_test declarative_debug
 
 
 #include <private/qqmlbinding_p.h>
 #include <private/qqmlboundsignal_p.h>
-#include <private/qqmlenginedebug_p.h>
 #include <private/qqmldebugservice_p.h>
 #include <private/qqmlmetatype_p.h>
 #include <private/qqmlproperty_p.h>
 
-#include "../shared/debugutil_p.h"
+#include "debugutil_p.h"
+#include "qqmlenginedebug_p.h"
 
 Q_DECLARE_METATYPE(QQmlDebugWatch::State)
 
-class tst_QQmlEngineDebug : public QObject
+class tst_QQmlEngineDebugService : public QObject
 {
     Q_OBJECT
 
@@ -127,7 +127,7 @@ signals:
 QML_DECLARE_TYPE(NonScriptProperty)
 
 
-QQmlDebugObjectReference tst_QQmlEngineDebug::findRootObject(int context, bool recursive)
+QQmlDebugObjectReference tst_QQmlEngineDebugService::findRootObject(int context, bool recursive)
 {
     QQmlDebugEnginesQuery *q_engines = m_dbg->queryAvailableEngines(this);
     waitForQuery(q_engines);
@@ -153,7 +153,7 @@ QQmlDebugObjectReference tst_QQmlEngineDebug::findRootObject(int context, bool r
     return result;
 }
 
-QQmlDebugPropertyReference tst_QQmlEngineDebug::findProperty(const QList<QQmlDebugPropertyReference> &props, const QString &name) const
+QQmlDebugPropertyReference tst_QQmlEngineDebugService::findProperty(const QList<QQmlDebugPropertyReference> &props, const QString &name) const
 {
     foreach(const QQmlDebugPropertyReference &p, props) {
         if (p.name() == name)
@@ -162,7 +162,7 @@ QQmlDebugPropertyReference tst_QQmlEngineDebug::findProperty(const QList<QQmlDeb
     return QQmlDebugPropertyReference();
 }
 
-void tst_QQmlEngineDebug::waitForQuery(QQmlDebugQuery *query)
+void tst_QQmlEngineDebugService::waitForQuery(QQmlDebugQuery *query)
 {
     QVERIFY(query);
     QCOMPARE(query->parent(), qobject_cast<QObject*>(this));
@@ -171,7 +171,7 @@ void tst_QQmlEngineDebug::waitForQuery(QQmlDebugQuery *query)
         QFAIL("query timed out");
 }
 
-void tst_QQmlEngineDebug::recursiveObjectTest(QObject *o, const QQmlDebugObjectReference &oref, bool recursive) const
+void tst_QQmlEngineDebugService::recursiveObjectTest(QObject *o, const QQmlDebugObjectReference &oref, bool recursive) const
 {
     const QMetaObject *meta = o->metaObject();
 
@@ -248,7 +248,7 @@ void tst_QQmlEngineDebug::recursiveObjectTest(QObject *o, const QQmlDebugObjectR
     }
 }
 
-void tst_QQmlEngineDebug::recursiveCompareObjects(const QQmlDebugObjectReference &a, const QQmlDebugObjectReference &b) const
+void tst_QQmlEngineDebugService::recursiveCompareObjects(const QQmlDebugObjectReference &a, const QQmlDebugObjectReference &b) const
 {
     QCOMPARE(a.debugId(), b.debugId());
     QCOMPARE(a.className(), b.className());
@@ -272,7 +272,7 @@ void tst_QQmlEngineDebug::recursiveCompareObjects(const QQmlDebugObjectReference
         recursiveCompareObjects(a.children()[i], b.children()[i]);
 }
 
-void tst_QQmlEngineDebug::recursiveCompareContexts(const QQmlDebugContextReference &a, const QQmlDebugContextReference &b) const
+void tst_QQmlEngineDebugService::recursiveCompareContexts(const QQmlDebugContextReference &a, const QQmlDebugContextReference &b) const
 {
     QCOMPARE(a.debugId(), b.debugId());
     QCOMPARE(a.name(), b.name());
@@ -286,7 +286,7 @@ void tst_QQmlEngineDebug::recursiveCompareContexts(const QQmlDebugContextReferen
         recursiveCompareContexts(a.contexts()[i], b.contexts()[i]);
 }
 
-void tst_QQmlEngineDebug::compareProperties(const QQmlDebugPropertyReference &a, const QQmlDebugPropertyReference &b) const
+void tst_QQmlEngineDebugService::compareProperties(const QQmlDebugPropertyReference &a, const QQmlDebugPropertyReference &b) const
 {
     QCOMPARE(a.objectDebugId(), b.objectDebugId());
     QCOMPARE(a.name(), b.name());
@@ -296,7 +296,7 @@ void tst_QQmlEngineDebug::compareProperties(const QQmlDebugPropertyReference &a,
     QCOMPARE(a.hasNotifySignal(), b.hasNotifySignal());
 }
 
-void tst_QQmlEngineDebug::initTestCase()
+void tst_QQmlEngineDebugService::initTestCase()
 {
     qRegisterMetaType<QQmlDebugWatch::State>();
     qmlRegisterType<NonScriptProperty>("Test", 1, 0, "NonScriptPropertyElement");
@@ -394,7 +394,7 @@ void tst_QQmlEngineDebug::initTestCase()
     QTRY_VERIFY(m_dbg->state() == QQmlEngineDebug::Enabled);
 }
 
-void tst_QQmlEngineDebug::cleanupTestCase()
+void tst_QQmlEngineDebugService::cleanupTestCase()
 {
     delete m_dbg;
     delete m_conn;
@@ -402,7 +402,7 @@ void tst_QQmlEngineDebug::cleanupTestCase()
     delete m_engine;
 }
 
-void tst_QQmlEngineDebug::setMethodBody()
+void tst_QQmlEngineDebugService::setMethodBody()
 {
     QQmlDebugObjectReference obj = findRootObject(2);
 
@@ -439,7 +439,7 @@ void tst_QQmlEngineDebug::setMethodBody()
     }
 }
 
-void tst_QQmlEngineDebug::watch_property()
+void tst_QQmlEngineDebugService::watch_property()
 {
     QQmlDebugObjectReference obj = findRootObject();
     QQmlDebugPropertyReference prop = findProperty(obj.properties(), "width");
@@ -484,7 +484,7 @@ void tst_QQmlEngineDebug::watch_property()
     QCOMPARE(spy.at(0).at(1).value<QVariant>(), qVariantFromValue(origWidth*2));
 }
 
-void tst_QQmlEngineDebug::watch_object()
+void tst_QQmlEngineDebugService::watch_object()
 {
     QQmlDebugEnginesQuery *q_engines = m_dbg->queryAvailableEngines(this);
     waitForQuery(q_engines);
@@ -557,7 +557,7 @@ void tst_QQmlEngineDebug::watch_object()
     QCOMPARE(newHeight, origHeight * 2);
 }
 
-void tst_QQmlEngineDebug::watch_expression()
+void tst_QQmlEngineDebugService::watch_expression()
 {
     QFETCH(QString, expr);
     QFETCH(int, increment);
@@ -620,7 +620,7 @@ void tst_QQmlEngineDebug::watch_expression()
     }
 }
 
-void tst_QQmlEngineDebug::watch_expression_data()
+void tst_QQmlEngineDebugService::watch_expression_data()
 {
     QTest::addColumn<QString>("expr");
     QTest::addColumn<int>("increment");
@@ -630,21 +630,21 @@ void tst_QQmlEngineDebug::watch_expression_data()
     QTest::newRow("width+10") << "width + 10" << 10 << 5;
 }
 
-void tst_QQmlEngineDebug::watch_context()
+void tst_QQmlEngineDebugService::watch_context()
 {
     QQmlDebugContextReference c;
     QTest::ignoreMessage(QtWarningMsg, "QQmlEngineDebug::addWatch(): Not implemented");
     QVERIFY(!m_dbg->addWatch(c, QString(), this));
 }
 
-void tst_QQmlEngineDebug::watch_file()
+void tst_QQmlEngineDebugService::watch_file()
 {
     QQmlDebugFileReference f;
     QTest::ignoreMessage(QtWarningMsg, "QQmlEngineDebug::addWatch(): Not implemented");
     QVERIFY(!m_dbg->addWatch(f, this));
 }
 
-void tst_QQmlEngineDebug::queryAvailableEngines()
+void tst_QQmlEngineDebugService::queryAvailableEngines()
 {
     QQmlDebugEnginesQuery *q_engines;
 
@@ -679,7 +679,7 @@ void tst_QQmlEngineDebug::queryAvailableEngines()
     m_dbg = new QQmlEngineDebug(m_conn, this);
 }
 
-void tst_QQmlEngineDebug::queryRootContexts()
+void tst_QQmlEngineDebugService::queryRootContexts()
 {
     QQmlDebugEnginesQuery *q_engines = m_dbg->queryAvailableEngines(this);
     waitForQuery(q_engines);
@@ -725,7 +725,7 @@ void tst_QQmlEngineDebug::queryRootContexts()
     m_dbg = new QQmlEngineDebug(m_conn, this);
 }
 
-void tst_QQmlEngineDebug::queryObject()
+void tst_QQmlEngineDebugService::queryObject()
 {
     QFETCH(bool, recursive);
 
@@ -797,7 +797,7 @@ void tst_QQmlEngineDebug::queryObject()
     }
 }
 
-void tst_QQmlEngineDebug::queryObject_data()
+void tst_QQmlEngineDebugService::queryObject_data()
 {
     QTest::addColumn<bool>("recursive");
 
@@ -805,7 +805,7 @@ void tst_QQmlEngineDebug::queryObject_data()
     QTest::newRow("recursive") << true;
 }
 
-void tst_QQmlEngineDebug::queryExpressionResult()
+void tst_QQmlEngineDebugService::queryExpressionResult()
 {
     QFETCH(QString, expr);
     QFETCH(QVariant, result);
@@ -846,7 +846,7 @@ void tst_QQmlEngineDebug::queryExpressionResult()
     m_dbg = new QQmlEngineDebug(m_conn, this);
 }
 
-void tst_QQmlEngineDebug::queryExpressionResult_data()
+void tst_QQmlEngineDebugService::queryExpressionResult_data()
 {
     QTest::addColumn<QString>("expr");
     QTest::addColumn<QVariant>("result");
@@ -861,7 +861,7 @@ void tst_QQmlEngineDebug::queryExpressionResult_data()
     QTest::newRow("varObjMap") << "varObjMap" << qVariantFromValue(map);
 }
 
-void tst_QQmlEngineDebug::tst_QQmlDebugFileReference()
+void tst_QQmlEngineDebugService::tst_QQmlDebugFileReference()
 {
     QQmlDebugFileReference ref;
     QVERIFY(ref.url().isEmpty());
@@ -885,7 +885,7 @@ void tst_QQmlEngineDebug::tst_QQmlDebugFileReference()
     }
 }
 
-void tst_QQmlEngineDebug::tst_QQmlDebugEngineReference()
+void tst_QQmlEngineDebugService::tst_QQmlDebugEngineReference()
 {
     QQmlDebugEngineReference ref;
     QCOMPARE(ref.debugId(), -1);
@@ -909,7 +909,7 @@ void tst_QQmlEngineDebug::tst_QQmlDebugEngineReference()
     }
 }
 
-void tst_QQmlEngineDebug::tst_QQmlDebugObjectReference()
+void tst_QQmlEngineDebugService::tst_QQmlDebugObjectReference()
 {
     QQmlDebugObjectReference ref;
     QCOMPARE(ref.debugId(), -1);
@@ -942,7 +942,7 @@ void tst_QQmlEngineDebug::tst_QQmlDebugObjectReference()
         recursiveCompareObjects(r, ref);
 }
 
-void tst_QQmlEngineDebug::tst_QQmlDebugContextReference()
+void tst_QQmlEngineDebugService::tst_QQmlDebugContextReference()
 {
     QQmlDebugContextReference ref;
     QCOMPARE(ref.debugId(), -1);
@@ -967,7 +967,7 @@ void tst_QQmlEngineDebug::tst_QQmlDebugContextReference()
         recursiveCompareContexts(r, ref);
 }
 
-void tst_QQmlEngineDebug::tst_QQmlDebugPropertyReference()
+void tst_QQmlEngineDebugService::tst_QQmlDebugPropertyReference()
 {
     QQmlDebugObjectReference rootObject = findRootObject();
     QQmlDebugObjectQuery *query = m_dbg->queryObject(rootObject, this);
@@ -990,7 +990,7 @@ void tst_QQmlEngineDebug::tst_QQmlDebugPropertyReference()
         compareProperties(r, ref);
 }
 
-void tst_QQmlEngineDebug::setBindingForObject()
+void tst_QQmlEngineDebugService::setBindingForObject()
 {
     QQmlDebugObjectReference rootObject = findRootObject();
     QVERIFY(rootObject.debugId() != -1);
@@ -1061,7 +1061,7 @@ void tst_QQmlEngineDebug::setBindingForObject()
     QCOMPARE(onEnteredRef.value(),  QVariant("{console.log('hello, world') }"));
 }
 
-void tst_QQmlEngineDebug::setBindingInStates()
+void tst_QQmlEngineDebugService::setBindingInStates()
 {
     // Check if changing bindings of propertychanges works
 
@@ -1153,7 +1153,7 @@ void tst_QQmlEngineDebug::setBindingInStates()
     QCOMPARE(findProperty(obj.properties(),"width").value().toInt(), 300);
 }
 
-void tst_QQmlEngineDebug::queryObjectTree()
+void tst_QQmlEngineDebugService::queryObjectTree()
 {
     const int sourceIndex = 3;
 
@@ -1227,9 +1227,9 @@ int main(int argc, char *argv[])
     _argv[_argc - 1] = arg;
 
     QGuiApplication app(_argc, _argv);
-    tst_QQmlEngineDebug tc;
+    tst_QQmlEngineDebugService tc;
     return QTest::qExec(&tc, _argc, _argv);
     delete _argv;
 }
 
-#include "tst_qqmlenginedebug.moc"
+#include "tst_qqmlenginedebugservice.moc"
index 010e97c..c24acca 100644 (file)
@@ -2,9 +2,10 @@ CONFIG += testcase
 TARGET = tst_qqmlinspector
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
-SOURCES += tst_qqmlinspector.cpp \
-           ../shared/debugutil.cpp
+SOURCES += tst_qqmlinspector.cpp
+
+INCLUDEPATH += ../shared
+include(../shared/debugutil.pri)
 
 DEFINES += SRCDIR=\\\"$$PWD\\\"
 CONFIG += parallel_test declarative_debug
index 81fe3d5..2bf43c9 100644 (file)
@@ -2,13 +2,13 @@ CONFIG += testcase
 TARGET = tst_qqmlprofilerservice
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
+SOURCES += tst_qqmlprofilerservice.cpp
 
-SOURCES += tst_qqmlprofilerservice.cpp \
-           ../shared/debugutil.cpp
-OTHER_FILES += data/test.qml
+INCLUDEPATH += ../shared
+include(../../../shared/util.pri)
+include(../shared/debugutil.pri)
 
-include (../../../shared/util.pri)
+OTHER_FILES += data/test.qml
 
 CONFIG += parallel_test declarative_debug
 
index edc120b..2b33ab3 100644 (file)
@@ -43,7 +43,8 @@
 #include <QLibraryInfo>
 
 #include "QtQml/private/qqmlprofilerservice_p.h"
-#include "../shared/debugutil_p.h"
+#include "debugutil_p.h"
+#include "qqmldebugclient.h"
 #include "../../../shared/util.h"
 
 #define PORT 13773
index e980d65..a8dd634 100644 (file)
@@ -2,12 +2,11 @@ CONFIG += testcase
 TARGET = tst_qv8profilerservice
 macx:CONFIG -= app_bundle
 
-HEADERS += ../shared/debugutil_p.h
+SOURCES += tst_qv8profilerservice.cpp
 
-SOURCES += tst_qv8profilerservice.cpp \
-           ../shared/debugutil.cpp
-
-include (../../../shared/util.pri)
+INCLUDEPATH += ../shared
+include(../../../shared/util.pri)
+include(../shared/debugutil.pri)
 
 OTHER_FILES += data/test.qml
 
index c5992a4..7b9cda9 100644 (file)
@@ -43,7 +43,8 @@
 #include <QLibraryInfo>
 
 #include "QtQml/private/qv8profilerservice_p.h"
-#include "../shared/debugutil_p.h"
+#include "debugutil_p.h"
+#include "qqmldebugclient.h"
 #include "../../../shared/util.h"
 
 #define PORT 13774
index a3d3dce..3d2f460 100644 (file)
@@ -44,9 +44,6 @@
 #include <QEventLoop>
 #include <QTimer>
 
-#include <private/qqmldebugclient_p.h>
-#include <private/qqmldebugservice_p.h>
-
 bool QQmlDebugTest::waitForSignal(QObject *receiver, const char *member, int timeout) {
     QEventLoop loop;
     QTimer timer;
diff --git a/tests/auto/qml/debugger/shared/debugutil.pri b/tests/auto/qml/debugger/shared/debugutil.pri
new file mode 100644 (file)
index 0000000..b74f6b0
--- /dev/null
@@ -0,0 +1,9 @@
+QT += core-private
+
+HEADERS += $$PWD/debugutil_p.h \
+           $$PWD/qqmldebugclient.h \
+           $$PWD/qqmlenginedebug_p.h
+SOURCES += $$PWD/debugutil.cpp \
+           $$PWD/qqmldebugclient.cpp \
+           $$PWD/qqmlenginedebug.cpp
+
index 194f8fa..177c712 100644 (file)
@@ -51,7 +51,7 @@
 
 #include <QtQml/qqmlengine.h>
 
-#include <private/qqmldebugclient_p.h>
+#include "qqmldebugclient.h"
 #include <private/qqmldebugservice_p.h>
 
 class QQmlDebugTest
 **
 ****************************************************************************/
 
-#include "qqmldebugclient_p.h"
+#include "qqmldebugclient.h"
 
-#include "qpacketprotocol_p.h"
+#include <private/qpacketprotocol_p.h>
 
 #include <QtCore/qdebug.h>
 #include <QtCore/qstringlist.h>
 #include <QtNetwork/qnetworkproxy.h>
 
-#include <private/qobject_p.h>
-
-QT_BEGIN_NAMESPACE
-
 const int protocolVersion = 1;
 const QString serverId = QLatin1String("QDeclarativeDebugServer");
 const QString clientId = QLatin1String("QDeclarativeDebugClient");
 
-class QQmlDebugClientPrivate : public QObjectPrivate
+class QQmlDebugClientPrivate
 {
-    Q_DECLARE_PUBLIC(QQmlDebugClient)
 public:
     QQmlDebugClientPrivate();
 
@@ -241,7 +236,7 @@ QQmlDebugConnection::~QQmlDebugConnection()
 {
     QHash<QString, QQmlDebugClient*>::iterator iter = d->plugins.begin();
     for (; iter != d->plugins.end(); ++iter) {
-        iter.value()->d_func()->connection = 0;
+        iter.value()->d->connection = 0;
         iter.value()->stateChanged(QQmlDebugClient::NotConnected);
     }
 }
@@ -341,9 +336,9 @@ QQmlDebugClientPrivate::QQmlDebugClientPrivate()
 
 QQmlDebugClient::QQmlDebugClient(const QString &name, 
                                                  QQmlDebugConnection *parent)
-    : QObject(*(new QQmlDebugClientPrivate), parent)
+    : QObject(parent),
+      d(new QQmlDebugClientPrivate)
 {
-    Q_D(QQmlDebugClient);
     d->name = name;
     d->connection = parent;
 
@@ -361,22 +356,20 @@ QQmlDebugClient::QQmlDebugClient(const QString &name,
 
 QQmlDebugClient::~QQmlDebugClient()
 {
-    Q_D(QQmlDebugClient);
     if (d->connection && d->connection->d) {
         d->connection->d->plugins.remove(d->name);
         d->connection->d->advertisePlugins();
     }
+    delete d;
 }
 
 QString QQmlDebugClient::name() const
 {
-    Q_D(const QQmlDebugClient);
     return d->name;
 }
 
 float QQmlDebugClient::serviceVersion() const
 {
-    Q_D(const QQmlDebugClient);
     if (d->connection->d->serverPlugins.contains(d->name))
         return d->connection->d->serverPlugins.value(d->name);
     return -1;
@@ -384,7 +377,6 @@ float QQmlDebugClient::serviceVersion() const
 
 QQmlDebugClient::State QQmlDebugClient::state() const
 {
-    Q_D(const QQmlDebugClient);
     if (!d->connection
             || !d->connection->isConnected()
             || !d->connection->d->gotHello)
@@ -398,7 +390,6 @@ QQmlDebugClient::State QQmlDebugClient::state() const
 
 void QQmlDebugClient::sendMessage(const QByteArray &message)
 {
-    Q_D(QQmlDebugClient);
     if (state() != Enabled)
         return;
 
@@ -416,6 +407,4 @@ void QQmlDebugClient::messageReceived(const QByteArray &)
 {
 }
 
-QT_END_NAMESPACE
-
 #include <qqmldebugclient.moc>
 #ifndef QQMLDEBUGCLIENT_H
 #define QQMLDEBUGCLIENT_H
 
-//
-//  W A R N I N G
-//  -------------
-//
-// This file is not part of the Qt API.  It exists purely as an
-// implementation detail.  This header file may change from version to
-// version without notice, or even be removed.
-//
-// We mean it.
-//
-
 #include <QtNetwork/qtcpsocket.h>
 
 #include <private/qtqmlglobal_p.h>
 
-QT_BEGIN_HEADER
-
-QT_BEGIN_NAMESPACE
-
-
 class QQmlDebugConnectionPrivate;
 class Q_QML_PRIVATE_EXPORT QQmlDebugConnection : public QIODevice
 {
@@ -120,12 +104,9 @@ protected:
     virtual void messageReceived(const QByteArray &);
 
 private:
+    QQmlDebugClientPrivate *d;
     friend class QQmlDebugConnection;
     friend class QQmlDebugConnectionPrivate;
 };
 
-QT_END_NAMESPACE
-
-QT_END_HEADER
-
 #endif // QQMLDEBUGCLIENT_H
similarity index 99%
rename from src/qml/debugger/qqmlenginedebug.cpp
rename to tests/auto/qml/debugger/shared/qqmlenginedebug.cpp
index 65af181..8a46c76 100644 (file)
 
 #include "qqmlenginedebug_p.h"
 
-#include "qqmldebugclient_p.h"
+#include "qqmldebugclient.h"
 
-#include "qqmlenginedebugservice_p.h"
+#include <private/qqmlenginedebugservice_p.h>
 
-#include <private/qobject_p.h>
-
-QT_BEGIN_NAMESPACE
+#include <QtCore/private/qobject_p.h>
 
 class QQmlEngineDebugClient : public QQmlDebugClient
 {
@@ -1068,5 +1066,3 @@ bool QQmlDebugPropertyReference::hasNotifySignal() const
     return m_hasNotifySignal;
 }
 
-QT_END_NAMESPACE
-
similarity index 99%
rename from src/qml/debugger/qqmlenginedebug_p.h
rename to tests/auto/qml/debugger/shared/qqmlenginedebug_p.h
index 0562d87..70f04d3 100644 (file)
 
 #include <private/qtqmlglobal_p.h>
 
-QT_BEGIN_HEADER
-
-QT_BEGIN_NAMESPACE
-
-
 class QQmlDebugConnection;
 class QQmlDebugWatch;
 class QQmlDebugPropertyWatch;
@@ -385,13 +380,9 @@ private:
     QVariant m_result;
 };
 
-QT_END_NAMESPACE
-
 Q_DECLARE_METATYPE(QQmlDebugEngineReference)
 Q_DECLARE_METATYPE(QQmlDebugObjectReference)
 Q_DECLARE_METATYPE(QQmlDebugContextReference)
 Q_DECLARE_METATYPE(QQmlDebugPropertyReference)
 
-QT_END_HEADER
-
 #endif // QQMLENGINEDEBUG_H
index 8aa4e67..54826a2 100644 (file)
@@ -44,7 +44,7 @@
 
 #include "profiledata.h"
 
-#include <QtQml/private/qqmldebugclient_p.h>
+#include "qqmldebugclient.h"
 #include <QtQml/private/qqmlprofilerservice_p.h>
 
 class ProfileClientPrivate;
index ec5f50e..db7e357 100644 (file)
@@ -2,7 +2,7 @@ TEMPLATE = app
 TARGET   = qmlprofiler
 DESTDIR = $$QT.qml.bins
 
-QT += qml qml-private network
+QT += qml qml-private network core-private
 
 target.path = $$[QT_INSTALL_BINS]
 INSTALLS += target
@@ -15,11 +15,13 @@ SOURCES += main.cpp \
     qmlprofilerapplication.cpp \
     commandlistener.cpp \
     profileclient.cpp \
-    profiledata.cpp
+    profiledata.cpp \
+    qqmldebugclient.cpp
 
 HEADERS += \
     qmlprofilerapplication.h \
     commandlistener.h \
     constants.h \
     profileclient.h \
-    profiledata.h
+    profiledata.h \
+    qqmldebugclient.h
similarity index 96%
rename from src/qml/debugger/qqmldebugclient.cpp
rename to tools/qmlprofiler/qqmldebugclient.cpp
index fcb0861..0453f88 100644 (file)
 **
 ****************************************************************************/
 
-#include "qqmldebugclient_p.h"
+#include "qqmldebugclient.h"
 
-#include "qpacketprotocol_p.h"
+#include <private/qpacketprotocol_p.h>
 
 #include <QtCore/qdebug.h>
 #include <QtCore/qstringlist.h>
 #include <QtNetwork/qnetworkproxy.h>
 
-#include <private/qobject_p.h>
-
-QT_BEGIN_NAMESPACE
-
 const int protocolVersion = 1;
 const QString serverId = QLatin1String("QDeclarativeDebugServer");
 const QString clientId = QLatin1String("QDeclarativeDebugClient");
 
-class QQmlDebugClientPrivate : public QObjectPrivate
+class QQmlDebugClientPrivate
 {
-    Q_DECLARE_PUBLIC(QQmlDebugClient)
 public:
     QQmlDebugClientPrivate();
 
@@ -241,7 +236,7 @@ QQmlDebugConnection::~QQmlDebugConnection()
 {
     QHash<QString, QQmlDebugClient*>::iterator iter = d->plugins.begin();
     for (; iter != d->plugins.end(); ++iter) {
-        iter.value()->d_func()->connection = 0;
+        iter.value()->d->connection = 0;
         iter.value()->stateChanged(QQmlDebugClient::NotConnected);
     }
 }
@@ -341,9 +336,9 @@ QQmlDebugClientPrivate::QQmlDebugClientPrivate()
 
 QQmlDebugClient::QQmlDebugClient(const QString &name, 
                                                  QQmlDebugConnection *parent)
-    : QObject(*(new QQmlDebugClientPrivate), parent)
+    : QObject(parent),
+      d(new QQmlDebugClientPrivate)
 {
-    Q_D(QQmlDebugClient);
     d->name = name;
     d->connection = parent;
 
@@ -361,22 +356,20 @@ QQmlDebugClient::QQmlDebugClient(const QString &name,
 
 QQmlDebugClient::~QQmlDebugClient()
 {
-    Q_D(QQmlDebugClient);
     if (d->connection && d->connection->d) {
         d->connection->d->plugins.remove(d->name);
         d->connection->d->advertisePlugins();
     }
+    delete d;
 }
 
 QString QQmlDebugClient::name() const
 {
-    Q_D(const QQmlDebugClient);
     return d->name;
 }
 
 float QQmlDebugClient::serviceVersion() const
 {
-    Q_D(const QQmlDebugClient);
     if (d->connection->d->serverPlugins.contains(d->name))
         return d->connection->d->serverPlugins.value(d->name);
     return -1;
@@ -384,7 +377,6 @@ float QQmlDebugClient::serviceVersion() const
 
 QQmlDebugClient::State QQmlDebugClient::state() const
 {
-    Q_D(const QQmlDebugClient);
     if (!d->connection
             || !d->connection->isConnected()
             || !d->connection->d->gotHello)
@@ -398,7 +390,6 @@ QQmlDebugClient::State QQmlDebugClient::state() const
 
 void QQmlDebugClient::sendMessage(const QByteArray &message)
 {
-    Q_D(QQmlDebugClient);
     if (state() != Enabled)
         return;
 
@@ -416,6 +407,4 @@ void QQmlDebugClient::messageReceived(const QByteArray &)
 {
 }
 
-QT_END_NAMESPACE
-
 #include <qqmldebugclient.moc>
similarity index 86%
rename from src/qml/debugger/qqmldebugclient_p.h
rename to tools/qmlprofiler/qqmldebugclient.h
index 064e15c..0f140a1 100644 (file)
 #ifndef QQMLDEBUGCLIENT_H
 #define QQMLDEBUGCLIENT_H
 
-//
-//  W A R N I N G
-//  -------------
-//
-// This file is not part of the Qt API.  It exists purely as an
-// implementation detail.  This header file may change from version to
-// version without notice, or even be removed.
-//
-// We mean it.
-//
-
 #include <QtNetwork/qtcpsocket.h>
 
-#include <private/qtqmlglobal_p.h>
-
-QT_BEGIN_HEADER
-
-QT_BEGIN_NAMESPACE
-
-
 class QQmlDebugConnectionPrivate;
-class Q_QML_PRIVATE_EXPORT QQmlDebugConnection : public QIODevice
+class QQmlDebugConnection : public QIODevice
 {
     Q_OBJECT
     Q_DISABLE_COPY(QQmlDebugConnection)
@@ -97,10 +79,9 @@ private:
 };
 
 class QQmlDebugClientPrivate;
-class Q_QML_PRIVATE_EXPORT QQmlDebugClient : public QObject
+class QQmlDebugClient : public QObject
 {
     Q_OBJECT
-    Q_DECLARE_PRIVATE(QQmlDebugClient)
     Q_DISABLE_COPY(QQmlDebugClient)
 
 public:
@@ -120,12 +101,9 @@ protected:
     virtual void messageReceived(const QByteArray &);
 
 private:
+    QQmlDebugClientPrivate *d;
     friend class QQmlDebugConnection;
     friend class QQmlDebugConnectionPrivate;
 };
 
-QT_END_NAMESPACE
-
-QT_END_HEADER
-
 #endif // QQMLDEBUGCLIENT_H