Fix warnings about nonexistent signals in QQuickScreen
authorOleg Shparber <trollixx@gmail.com>
Wed, 26 Dec 2012 02:15:49 +0000 (04:15 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Wed, 9 Jan 2013 15:43:17 +0000 (16:43 +0100)
On application exit QQuickScreen tries to disconnect
from an old QScreen which is almost destroyed at this
point.

Change-Id: I6c595cf68d6faaf3527b8ffcae0a074c23170ea1
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Alan Alpert <aalpert@rim.com>

src/quick/items/qquickscreen.cpp

index 139cd72..d82d646 100644 (file)
@@ -167,16 +167,8 @@ void QQuickScreenAttached::screenChanged(QScreen *screen)
         QScreen* oldScreen = m_screen;
         m_screen = screen;
 
-        if (oldScreen) {
-            disconnect(oldScreen, SIGNAL(geometryChanged(QRect)),
-                    this, SIGNAL(widthChanged()));
-            disconnect(oldScreen, SIGNAL(geometryChanged(QRect)),
-                    this, SIGNAL(heightChanged()));
-            disconnect(oldScreen, SIGNAL(orientationChanged(Qt::ScreenOrientation)),
-                    this, SIGNAL(orientationChanged()));
-            disconnect(oldScreen, SIGNAL(primaryOrientationChanged(Qt::ScreenOrientation)),
-                    this, SIGNAL(primaryOrientationChanged()));
-        }
+        if (oldScreen)
+            oldScreen->disconnect(this);
 
         if (!screen)
             return; //Don't bother emitting signals, because the new values are garbage anyways