- QString from ASCII conversion, remove global-static QString
variable from class.
- Signed/unsigned comparison.
- Unused variable.
Change-Id: I4ea3e72da85ba7ed329196d39085d7bba8bfa389
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
QT_BEGIN_NAMESPACE
-DEFINE_BOOL_CONFIG_OPTION(rewriteDump, QML_REWRITE_DUMP);
+DEFINE_BOOL_CONFIG_OPTION(rewriteDump, QML_REWRITE_DUMP)
namespace QQmlRewrite {
-QString SharedBindingTester::evalString("eval");
-
static void rewriteStringLiteral(AST::StringLiteral *ast, const QString *code, int startPosition, TextWriter *writer)
{
const unsigned position = ast->firstSourceLocation().begin() - startPosition + 1;
inline virtual bool visit(AST::FunctionDeclaration *);
inline virtual bool visit(AST::FunctionExpression *);
inline virtual bool visit(AST::IdentifierExpression *);
-
- static QString evalString;
};
class RewriteBinding: protected AST::Visitor
bool SharedBindingTester::visit(AST::IdentifierExpression *e)
{
+ static const QString evalString = QStringLiteral("eval");
if (e->name == evalString)
_sharable = false;
// Default to engine parent; this will be removed in the near future (QTBUG-24841)
QObject *parentArg = engine;
- unsigned consumedCount = 1;
+ int consumedCount = 1;
if (args.Length() > 1) {
const v8::Local<v8::Value> &lastArg = args[args.Length()-1];
void QQuickPathViewPrivate::handleMousePressEvent(QMouseEvent *event)
{
- Q_Q(QQuickPathView);
if (!interactive || !items.count() || !model || !modelCount)
return;
velocityBuffer.clear();